Skip to content

website: update (but not set) archive banner for 1.10 branch #4121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v1.10-branch
Choose a base branch
from

Conversation

thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented May 27, 2025

Checklist:

Description of your changes:

This is a back port of #4119 to the v1.10-branch, so that we only have to set the archived_version=true flag when we release 1.11 (and want to add the archive banner to the 1.10 branch.

NOTE: this does NOT add the banner right now to the 1.10 branch, it just makes it a single config to turn it on when we want to in the future (see the preview to confirm).

Labels

/area website

@google-oss-prow google-oss-prow bot added the area/website AREA: Website Styles/Hosting/Serving label May 27, 2025
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign franciscojavierarceo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thesuperzapper
Copy link
Member Author

@varodrig this is important to make sure we add the correct archive banner on the 1.10 branch (when we decide to do it).

Also, it's important we update the top right to show the current version as 1.10 on the 1.10 branch.

@varodrig
Copy link
Contributor

varodrig commented May 27, 2025

looks good and I see 1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website AREA: Website Styles/Hosting/Serving lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants