katib: Update LLM HP tuning guide to clarify tunable fields and fix resource section

[SanthoshToorpu]

…es config, remove unsupported params

Checklist:

• You have signed off your commits
• Ensure you follow best practices from our guide. Contributing.
• You have included screenshots when changing the website style or adding a new page.

Description of your changes:
As per andrey's recommendation I added the changes mentioned in the following screenshots attached. A minimal work.

Issue

Closes: #2522

Labels

/area katib

/area website

---

[google-oss-prow]

Hi @SanthoshToorpu. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[SanthoshToorpu]

@helenxie-bit please look into the changes

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gaocegege for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• content/en/docs/components/katib/OWNERS
• content/en/docs/components/trainer/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Arhell]

/ok-to-test

[SanthoshToorpu]

@andreyvelich as per @helenxie-bit instructions and after reading the thread i fixed 2/3 issues except for the params you told to remove irrelevant params.

I downloaded the docker image rn but can you be more specific on what to be removed and what not?

[helenxie-bit]

Thank you for this contribution! It helps a lot to make the user guide clearer. Here are a few suggestions:

[helenxie-bit]

I suggest we also move this part to the Training Operator doc and cross-reference it from this doc: https://github.com/kubeflow/website/blob/master/content/en/docs/components/trainer/legacy-v1/user-guides/fine-tuning.md

[SanthoshToorpu]

The S3 data params part? I guess that has rather less relevance to training operator. However if you are referencing to the example I believe that we should have a lil snippet that gives a high level overview as most people are lazy enough to browse nested links....

I'll commit with the three params removed. But please give me a heads up wrt the above suggestion

[helenxie-bit]

Yes, S3DatasetParams is another way to define an external dataset, just like HuggingfaceDatasetParams. So I think it makes sense to move its explanation into the Training Operator documentation as well.

[helenxie-bit]

@andreyvelich as per @helenxie-bit instructions and after reading the thread i fixed 2/3 issues except for the params you told to remove irrelevant params.

I downloaded the docker image rn but can you be more specific on what to be removed and what not?

I think we need to remove unused parameters in this part: https://www.kubeflow.org/docs/components/katib/user-guides/llm-hp-optimization/#key-parameters-for-llm-hyperparameter-tuning. Can you remove parameters objective, base_image, and parameters? Since they will not be used when optimizing hyperparameters for LLMs.

[helenxie-bit]

Ref issue: kubeflow/katib#2522

[SanthoshToorpu]

@andreyvelich as per @helenxie-bit instructions and after reading the thread i fixed 2/3 issues except for the params you told to remove irrelevant params.

I downloaded the docker image rn but can you be more specific on what to be removed and what not?

I think we need to remove unused parameters in this part: https://www.kubeflow.org/docs/components/katib/user-guides/llm-hp-optimization/#key-parameters-for-llm-hyperparameter-tuning. Can you remove parameters objective, base_image, and parameters? Since they will not be used when optimizing hyperparameters for LLMs.

Okay so only those threee params?

[helenxie-bit]

@andreyvelich as per @helenxie-bit instructions and after reading the thread i fixed 2/3 issues except for the params you told to remove irrelevant params.

I downloaded the docker image rn but can you be more specific on what to be removed and what not?

I think we need to remove unused parameters in this part: https://www.kubeflow.org/docs/components/katib/user-guides/llm-hp-optimization/#key-parameters-for-llm-hyperparameter-tuning. Can you remove parameters objective, base_image, and parameters? Since they will not be used when optimizing hyperparameters for LLMs.

Okay so only those threee params?

Yes, all other parameters may be used when optimizing hyperparameters for LLMs.

[SanthoshToorpu]

@helenxie-bit :Great! Maybe here it's better to use a different title since we include S3DatasetParams in this part too:

how about

Dataset and Model Parameter Classes

in legacy trainer docs

[helenxie-bit]

@helenxie-bit :Great! Maybe here it's better to use a different title since we include S3DatasetParams in this part too:

how about

Dataset and Model Parameter Classes

in legacy trainer docs

That sounds good to me.

[SanthoshToorpu]

Please review

[helenxie-bit]

Thanks for the contribution! LGTM! Please have a review when you have time @andreyvelich @mahdikhashan

[mahdikhashan]

/assign