-
Notifications
You must be signed in to change notification settings - Fork 50
feat(ws): Notebooks v2 Create Workspace Kind/ Creation method #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: notebooks-v2
Are you sure you want to change the base?
feat(ws): Notebooks v2 Create Workspace Kind/ Creation method #365
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8e7a660
to
14c46fb
Compare
Signed-off-by: Charles Thao <[email protected]>
6eefe0a
to
c494a10
Compare
Signed-off-by: Charles Thao <[email protected]>
Signed-off-by: Charles Thao <[email protected]>
c494a10
to
f63b77a
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thaorell , thanks for the PR!
@jenny-s51 This first step of the wizard introduces a "new concept" for the UI, if you give it a a try and share your opinion, it would really help us.
IMO, we should keep the Create Workspace Kind
button commented during the development of this epic, until the whole wizard is done. The reviewers can access the http://localhost:9000/workspacekinds/create
URL directly to test it, or uncomment the button locally if they wish.
{/* <Button variant="primary" ouiaId="Primary"> | ||
Create Workspace Kind // Todo: show only in case of an admin user. | ||
</Button> */} | ||
<Button variant="primary" ouiaId="Primary" onClick={createWorkspaceKind}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thaorell The way to add the creation button besides the filter is changing in the Workspaces UI, please consider using the same approach here. The last step of this change is on #364 by @jenny-s51 , which is about to be merged.
This PR encapsulates a Create Workspace Kind Wizard and its first step for the user to select the creation method
closes: #349
screencast-localhost_9000-2025_05_20-16_14_04.webm