Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix flaky tests caused by tests shared status.
Problem
If test
com.github.kevinsawicki.http.HttpRequestTest#customConnectionFactory
runs before other tests, such ascom.github.kevinsawicki.http.HttpRequestTest#headWithEscapedMappedQueryParams
, the latter one will fail:A full list of tests that can be polluted by the shared status include 28 tests:
Root cause and fix
The test failure is caused by the shared status pollution from
com.github.kevinsawicki.http.HttpRequestTest#customConnectionFactory
, it sets a newConnectionFactory
but doesn't reset its status at the end of the test, thus leads to other test failures. To clear the pollution, we should reset theConnectionFactory
in teardown methods.