-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new forgejo scaler #6495
Open
cobak78
wants to merge
3
commits into
kedacore:main
Choose a base branch
from
cobak78:forgejo-runner-scaler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
new forgejo scaler #6495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cobak78
force-pushed
the
forgejo-runner-scaler
branch
from
January 22, 2025 14:43
03fd3a1
to
39fd60d
Compare
cobak78
force-pushed
the
forgejo-runner-scaler
branch
2 times, most recently
from
January 23, 2025 11:41
5b9d520
to
f13dbc7
Compare
JorTurFer
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution! I've left some comment inline. Additionally to them:
- Please, add an e2e test covering the scaler. You get more info about how to do it here
- Could you open a PR to docs adding the scaler in next version?
- All commits must be signed and that's why DCO check is failing, please rebase your branch signing all the commits (how to do that it's explained in the check page)
cobak78
force-pushed
the
forgejo-runner-scaler
branch
5 times, most recently
from
January 29, 2025 09:27
5a3c0bd
to
6b7ca20
Compare
Signed-off-by: jaime merino <[email protected]>
Signed-off-by: jaime merino <[email protected]>
Signed-off-by: jaime merino <[email protected]>
cobak78
force-pushed
the
forgejo-runner-scaler
branch
from
January 29, 2025 09:45
6b7ca20
to
a63882e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new forgejo autoscaler with the same characteristics of the github autoscaler.
Here is the issue for this feature #6488
Another important discussions on this topic:
Checklist