-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger Schema Generated Tool #6489
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is simply awesome! Could I suggest generating the output also as json as add a verification step during the CI to verify that the generated schemas are up to date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is simply awesome! Could I suggest generating the output also as json as add a verification step during the CI to verify that the generated schemas are up-to-date?
And probably we want to pull the schema during the release too, using the specific version of the release
Sure, will add json as one more output file formate. |
Signed-off-by: SpiritZhou <[email protected]>
Generating trigger metadata schema according to new declarative scaler configuration, which can be used for validation or other related improvement.
Input:
make generate-scaler-schemas [--keda-version][--scalers-builder-file][--scalers-files-dir][--specify-scaler][--output-file-path]
Output:
scaler-metadata-schemas.yaml
Checklist
Relates to # #6345