-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scaler): Add TLS support for Artemis scaler #6474
base: main
Are you sure you want to change the base?
feat(scaler): Add TLS support for Artemis scaler #6474
Conversation
Initial implementation for TLS support in Artemis Scaler. Issue: kedacore#6448 Signed-off-by: Chirag Bhatia <[email protected]>
Signed-off-by: Chirag Bhatia <[email protected]>
…HTTPProtocol/natsStreamingHTTPSProtocol Issue: kedacore#6448 Signed-off-by: Chirag Bhatia <[email protected]>
Issue: kedacore#6448 Signed-off-by: Chirag Bhatia <[email protected]>
// do we need to guarantee this timeout for a specific | ||
// reason? if not, we can have buildScaler pass in | ||
// the global client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We pass the value here because it can be changed via ENV by users and some scaler allow overriding it via scaler configuration. Said this, maybe we should move the env evaluation to the http package and add another builder to build the client with another different timeout. This could make the code cleaner @wozniakjan @zroubalik ?
// do we need to guarantee this timeout for a specific | |
// reason? if not, we can have buildScaler pass in | |
// the global client |
Checking the current options, I'm wondering if a Builder patter can make sense in general to configure all the parameters of the HTTP client as currently we are calling multiple times to the same code, e.g: To create a client with an specific transport, we create the client (which creates a TLS config and a transport) and then we create the new transport and replace the just default created one.
I'm thinking about something like:
client, err := kedautil.NewHTTPClientBuilder().WithTimeout(...).WithTransport(...).With...Build()
It's more verbose but more efficient too, and it shouldn't be a huge change in terms of changes (to address them in another PR. If we agree with changing this, I'll create another issue)
Description
This PR introduces TLS support for the Artemis scaler, allowing secure communication with Artemis brokers.
Checklist
Related Issues and PRs
Fixes #6448
Notes
This PR includes:
Testing TLS functionality directly in an e2e environment might require additional configuration.