Skip to content

add test for zdepth package #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add test for zdepth package #425

wants to merge 5 commits into from

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Jan 26, 2023 •
edited
Loading

Merge after #2762
Waiting for upstream: jsk-ros-pkg/jsk_recognition#2762

add test for zdepth package

@knorth55 knorth55 changed the title [Merge after #2762][Wait for upstream] add test for zdepth package [Wait for upstream] add test for zdepth package Jan 27, 2023
k-okada
k-okada reviewed Jan 27, 2023
View reviewed changes
@knorth55 knorth55 changed the title [Wait for upstream] add test for zdepth package add test for zdepth package May 15, 2025
@knorth55 knorth55 requested a review from k-okada May 15, 2025 02:18
@k-okada
Copy link
Member

k-okada commented May 15, 2025

failed on melodic?

2025-05-15T02:35:54.2818582Z [zdepth_image_transport:make]   File "/opt/ros/melodic/lib/python2.7/dist-packages/roslaunch/substitution_args.py", line 212, in _find_executable
2025-05-15T02:35:54.2822110Z 
2025-05-15T02:35:54.2822297Z                                                                                 
2025-05-15T02:35:54.2823026Z [zdepth_image_transport:make]     full_path = _get_executable_path(rp.get_path(args[0]), path)
2025-05-15T02:35:54.2823556Z 
2025-05-15T02:35:54.2823713Z                                                                                 
2025-05-15T02:35:54.2824515Z [zdepth_image_transport:make]   File "/usr/lib/python2.7/dist-packages/rospkg/rospack.py", line 207, in get_path
2025-05-15T02:35:54.2825157Z 
2025-05-15T02:35:54.2825170Z 
2025-05-15T02:35:54.2825324Z                                                                                 
2025-05-15T02:35:54.2825987Z [zdepth_image_transport:make]     raise ResourceNotFound(name, ros_paths=self._ros_paths)
2025-05-15T02:35:54.2828384Z 
2025-05-15T02:35:54.2828560Z 
2025-05-15T02:35:54.2828779Z                                                                                 
2025-05-15T02:35:54.2829702Z [zdepth_image_transport:make] rospkg.common.ResourceNotFound: depth_image_publisher
2025-05-15T02:35:54.2830304Z 
2025-05-15T02:35:54.2830472Z                                                                                 
2025-05-15T02:35:54.2831121Z [zdepth_image_transport:make] ROS path [0]=/opt/ros/melodic/share/ros
2025-05-15T02:35:54.2831577Z 
2025-05-15T02:35:54.2831749Z                                                                                 
2025-05-15T02:35:54.2832609Z [zdepth_image_transport:make] ROS path [1]=/github/home/ros/ws_jsk_3rdparty/src/jsk_3rdparty/zdepth_image_transport
2025-05-15T02:35:54.2833287Z 
2025-05-15T02:35:54.2833579Z                                                                                 
2025-05-15T02:35:54.2834405Z [zdepth_image_transport:make] ROS path [2]=/github/home/ros/ws_jsk_3rdparty/src/jsk_3rdparty/3rdparty/aques_talk
2025-05-15T02:35:54.2835123Z 
2025-05-15T02:35:54.2835279Z                                                                                 
2025-05-15T02:35:54.2836248Z [zdepth_image_transport:make] ROS path [3]=/github/home/ros/ws_jsk_3rdparty/src/jsk_3rdparty/3rdparty/assimp_devel
2025-05-15T02:35:54.2836928Z 
2025-05-15T02:35:54.2837079Z                                                                                 
2025-05-15T02:35:54.2837936Z [zdepth_image_transport:make] ROS path [4]=/github/home/ros/ws_jsk_3rdparty/src/jsk_3rdparty/bayesian_belief_networks
2025-05-15T02:35:54.2838616Z 
2025-05-15T02:35:54.2838774Z                                                                                 
2025-05-15T02:35:54.2839752Z [zdepth_image_transport:make] ROS path [5]=/github/home/ros/ws_jsk_3rdparty/src/jsk_3rdparty/chaplus_ros

@knorth55
Copy link
Member Author

depth_image_publisher will only be released in noetic.
ros/rosdistro#45766

@knorth55
Copy link
Member Author

I change to

  • run test in noetic only
  • install jsk_recognition in .travis.rosinstall.noetic
    • waiting for depth_image_publisher release in noetic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-okada k-okada Awaiting requested review from k-okada

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement waitForUpstream zdepth_image_transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knorth55 @k-okada