address feedback

jorisvandenbossche · Nov 23, 2023 · 2f28037 · 2f28037
1 parent 02b3dce
commit 2f28037
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/cpp/src/arrow/filesystem/s3fs.cc b/cpp/src/arrow/filesystem/s3fs.cc
@@ -2410,9 +2410,10 @@ class S3FileSystem::Impl : public std::enable_shared_from_this<S3FileSystem::Imp
                     DCHECK_GT(file_info.path().size(), bucket.size());
                     auto file_path = file_info.path().substr(bucket.size() + 1);
                     if (file_info.IsDirectory()) {
+                      DCHECK(internal::AssertNoTrailingSlash(file_path));
                       file_path = file_path + kSep;
                     }
-                    file_paths.push_back(file_path);
+                    file_paths.push_back(std::move(file_path));
                   }
                   scheduler->AddSimpleTask(
                       [=, file_paths = std::move(file_paths)] {