Skip to content

Fix pkg_resources deprecation #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2023
Merged

Fix pkg_resources deprecation #409

merged 2 commits into from
Apr 3, 2023

Conversation

beroda
Copy link
Contributor

@beroda beroda commented Apr 1, 2023

Closes #408

@beroda
Copy link
Contributor Author

beroda commented Apr 1, 2023 •
edited
Loading

The workflow should be failing due to pkg_resources deprecation. Waiting to see it failing as expected and the next commits should fix it.

@beroda beroda changed the title Convert deprecation warning to error in tests Fix pkg_resources deprecation Apr 1, 2023
@beroda beroda marked this pull request as ready for review April 2, 2023 12:23
@beroda
Copy link
Contributor Author

beroda commented Apr 2, 2023

I don't really understand why the first pipeline did not failed as I expected ... I tried on my machine with the same config and it failed.

Never mind, pkg_resources is now replaced by importlib_metadata. I will do the same for jonathf/numpoly#95

@jonathf jonathf merged commit af3dbfe into jonathf:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Depreciation pkg_resources
2 participants
@beroda @jonathf