Skip to content

Fix flaky StatisticsHandlerTest #13096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: jetty-12.1.x
Choose a base branch
from

Conversation

lorban
Copy link
Contributor

@lorban lorban commented May 5, 2025

As explained here, StatisticsHandlerTest currently can run in parallel with DistributionTests.

Fixes #13094

@lorban lorban requested review from olamy and sbordet May 5, 2025 12:11
@lorban lorban self-assigned this May 5, 2025
@olamy
Copy link
Member

olamy commented May 5, 2025

Why cannot run in parallel?
Distribution tests are separate jvm.

Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lorban, I agree with @olamy: there should not be interaction as they are different JVMs.

@lorban
Copy link
Contributor Author

lorban commented May 6, 2025

I wanted to try this out to see if it helps, as this failure isn't locally reproducible and it happens at a weird time: during create-startd.

@joakime spoke about DistributionTests.testHTTP2ClientInCoreWebAppProvidedByServer failures being caused by jetty.org being down. I wonder if the same problem could impact testWebAppWithProxyAndJPMS and StatisticsHandlerTest?

@olamy
Copy link
Member

olamy commented May 6, 2025

Should we mark those tests as external?
Or during distribution testing just start a simple docker Nginx and "hit" it instead of webtide.com or some javadoc?

@sbordet
Copy link
Contributor

sbordet commented May 6, 2025

Why would we need to access jetty.org? For XML DTD download? We should have those locally.

@olamy
Copy link
Member

olamy commented May 6, 2025

Why would we need to access jetty.org? For XML DTD download? We should have those locally.

not sure it;s related to DTD but simply hitting webtide.com see test webapp code used by the distribution test:

@lorban lorban force-pushed the fix/jetty-12.1.x/13094-StatisticsHandlerTest branch from 9bb92f6 to a5b77d2 Compare May 7, 2025 12:29
@lorban lorban moved this to 🏗 In progress in Jetty 12.1.0 May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

3 participants