-
-
Notifications
You must be signed in to change notification settings - Fork 11
feat: pr comment generator for covector preview #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1d1e108
to
a759240
Compare
The following preview packages have been published by Covector:
|
3bc4036
to
61d36d1
Compare
I know that feeling 😄
Oh I like that thought. Perhaps we should address this issue in this PR? We will likely want to add some tests around it to confirm that we are actually returning properly. Particularly in case something inside covector changes, we don't accidentally break comments. We could probably mock out the comment generation much like I mocked out the Github Release to confirm that our inputs are indeed correct.
I think I agree with all of this. Perhaps we decide to adjust in the future, but I think this is a great as is. |
aa35df9
to
33edeac
Compare
1c40296
to
5b5d9de
Compare
One question that I thought of this morning... Should we update / keep the first comment up to date with the released version? I think you haven't, and I also feel like the answer should be "no". However, I just wanted to explicitly rule it out if you agree. |
What do you mean? |
The bot could create a message initially, and after each commit edit and update the first message with the newly published packages. As opposed to adding a new comment every time a new publish happens. |
Oh yeah it does that right now. I tag the covector-generated comment with a hidden |
Oh cool perfect 👍 |
d559317
to
670048b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers! Feel free to merge this after we get #187 merged in.
Motivation
To finish off the works of #179 and #187.
Approach
Covector did not publish any preview packages
The following preview packages have been published by Covector: ...
(see real example below)github-action
bot) if we pass in the bot's token in the workflow.action
patchTODOs
Typescript could use some work...L8RIt's already been mentioned in feat: add preview command to covector #187 but the boolean that determines if a package has been published or not is never toggled (I think it's just one of those things that's been overlooked). Covector will rely on this boolean for generating its PR comments.Separate PRSee example of comment template down below. We could fancy it up with a table if you'd like. I like having it as one string so it's easier to copy and paste to the terminal.Separate PR