-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #557 - added support to cognito user pool limit #558
base: develop
Are you sure you want to change the base?
Conversation
The doc build is failing, not sure how to proceed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luchees Thanks so much for this. I've only glanced over the code so far, but it looks good to me aside from one comment I made.
You can ignore the docs build failure, I'll fix that in the develop branch. It appears that TravisCI changed their URL structure, and the old URL to the build is now 404.
Codecov Report
@@ Coverage Diff @@
## develop #558 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 45 +1
Lines 3294 3322 +28
Branches 485 487 +2
=========================================
+ Hits 3294 3322 +28
Continue to review full report at Codecov.
|
@jantman Thanks for the comment I indeed looked over that unused function. Removed it. Now I got the hang of the setup and will try to implement more use cases I have. |
@jantman Hello, is it possible to merge this PR? |
Summary
adds support for Cognito service, user pool limits
Pull Request Checklist
writing tests for the code, that's fine, just mention that in the summary and either
ask for assistance, or clarify that you'd like someone else to handle the tests. PRs that
include complete test coverage will usually be merged faster.
tox -e docs
connect()
andconnect_resource()
methods, inherited fromawslimitchecker.connectable.Connectable
if you're working on a GitHub issue (i.e. "issue #x - "). Please
refrain from using the "fixes #x" notation unless you are sure that the
the issue is fixed in that commit.
Contributor License Agreement
By submitting this work for inclusion in awslimitchecker, I agree to the following terms:
is being made under the same license as the awslimitchecker project (the Affero GPL v3,
or any subsequent version of that license if adopted by awslimitchecker).
this pull request grants a perpetual, global, unlimited license for it to be used and distributed
under the terms of awslimitchecker's license.