Clarify relationship btw MeshNetworks and ENABLE_HCM_INTERNAL_NET #3433
Conversation
Add comments explaining the ability to use MeshNetworks to configure Envoy's internal_address_config via ENABLE_HCM_INTERNAL_NETWORK Signed-off-by: Jackie Elliott <[email protected]>
jaellio
added
the
cherrypick/release-1.25
|
😊 Welcome @jaellio! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/XS
Signed-off-by: Jackie Elliott <[email protected]>
istio-testing
added
size/S
| @@ -114,6 +114,9 @@ message Network { | |||
| // locality: us-east-1a | |||
| // ``` | |||
| // | |||
| // If `ENABLE_HCM_INTERNAL_NETWORKS` is set to true, MeshNetworks can be used to | |||
There was a problem hiding this comment.
Do you think we need an example of how to do this?
There was a problem hiding this comment.
If Networks defaults to all mesh IPs then maybe not, but I need to clarify the default value of Networks
There was a problem hiding this comment.
From my quick investigation, I don't think there is a default Network configured. I had previously thought it defaulted to all mesh IPs. @ramaraochavali Since you are more familiar with this configuration could confirm this and review an additional example?
and configuring MeshNetworks. Signed-off-by: Jackie Elliott <[email protected]>
istio-testing
added
size/M
Add comments explaining the ability to use MeshNetworks to configure Envoy's internal_address_config via
ENABLE_HCM_INTERNAL_NETWORK
istio/istio#53402
Related: istio/istio#52037