refactor: Use Box<str> instead of String for tmux::Popup

iovis · Jan 11, 2024 · eb0187e · eb0187e
1 parent b86d0b1
commit eb0187e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/tmux/init.rs b/src/tmux/init.rs
@@ -97,15 +97,15 @@ fn bind_settings(tmux_command: &mut Command, settings: &Settings) {
             tmux_command
                 .arg("popup")
                 .arg("-w")
-                .arg(width)
+                .arg(width.as_ref())
                 .arg("-h")
-                .arg(height)
+                .arg(height.as_ref())
                 .arg("-b")
                 .arg("rounded")
                 .arg("-E");
 
             if let Some(title) = title {
-                tmux_command.arg("-T").arg(title);
+                tmux_command.arg("-T").arg(title.as_ref());
             }
         } else {
             tmux_command.arg("run");

diff --git a/src/tmux/popup.rs b/src/tmux/popup.rs
@@ -2,13 +2,13 @@ use serde::{Deserialize, Serialize};
 
 #[derive(Debug, Deserialize, Serialize, PartialEq, Eq)]
 pub struct Popup {
-    pub title: Option<String>,
+    pub title: Option<Box<str>>,
     #[serde(default = "default_popup_dimension")]
-    pub width: String,
+    pub width: Box<str>,
     #[serde(default = "default_popup_dimension")]
-    pub height: String,
+    pub height: Box<str>,
 }
 
-fn default_popup_dimension() -> String {
-    "75%".to_string()
+fn default_popup_dimension() -> Box<str> {
+    "75%".into()
 }