Skip to content

feat(modal): add IonModalToken for injecting modal elements in Angular components #16451

feat(modal): add IonModalToken for injecting modal elements in Angular components

feat(modal): add IonModalToken for injecting modal elements in Angular components #16451

Triggered via pull request June 13, 2025 15:55
@ShaneKShaneK
synchronize #30474
FW-6475
Status Success
Total duration 9m 54s
Artifacts 27

build.yml

on: pull_request
build-react
46s
build-react
build-vue
33s
build-vue
Matrix: test-core-screenshot
build-angular
58s
build-angular
build-angular-server
31s
build-angular-server
test-core-clean-build
11s
test-core-clean-build
test-core-lint
48s
test-core-lint
test-core-spec
38s
test-core-spec
build-react-router
24s
build-react-router
build-vue-router
37s
build-vue-router
verify-screenshots
3s
verify-screenshots
Matrix: test-angular-e2e
Matrix: test-react-e2e
Matrix: test-react-router-e2e
Matrix: test-vue-e2e
verify-test-angular-e2e
3s
verify-test-angular-e2e
verify-test-react-e2e
3s
verify-test-react-e2e
verify-test-react-router-e2e
4s
verify-test-react-router-e2e
verify-test-vue-e2e
3s
verify-test-vue-e2e
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 20 notices
[Mobile Chrome] › src/components/datetime/test/locale/datetime.e2e.ts:42:11 › datetime: locale - md/ltr › ja-JP › month/year picker should not have visual regressions: src/components/datetime/test/locale/datetime.e2e.ts#L166
1) [Mobile Chrome] › src/components/datetime/test/locale/datetime.e2e.ts:42:11 › datetime: locale - md/ltr › ja-JP › month/year picker should not have visual regressions Error: expect(locator).toHaveScreenshot(expected) 266 pixels (ratio 0.01 of all image pixels) are different. Expected: /ionic/src/components/datetime/test/locale/datetime.e2e.ts-snapshots/datetime-locale-ja-JP-month-year-diff-md-ltr-Mobile-Chrome-linux.png Received: /ionic/test-results/src-components-datetime-te-18862-not-have-visual-regressions-Mobile-Chrome/datetime-locale-ja-JP-month-year-diff-md-ltr-actual.png Diff: /ionic/test-results/src-components-datetime-te-18862-not-have-visual-regressions-Mobile-Chrome/datetime-locale-ja-JP-month-year-diff-md-ltr-diff.png Call log: - expect.toHaveScreenshot(datetime-locale-ja-JP-month-year-diff-md-ltr.png) with timeout 5000ms - verifying given screenshot expectation - waiting for locator('ion-datetime') - locator resolved to <ion-datetime max="2022" locale="ja-JP" show-default-title="true" presentation="month-year" show-default-buttons="true" value="2022-04-19T04:20:00" class="ion-color ion-color-primary md show-month-and-year datetime-presentation-month-year datetime-size-fixed hydrated datetime-ready">…</ion-datetime> - taking element screenshot - disabled all CSS animations - waiting for fonts to load... - fonts loaded - attempting scroll into view action - waiting for element to be stable - 266 pixels (ratio 0.01 of all image pixels) are different. - waiting 100ms before taking screenshot - waiting for locator('ion-datetime') - locator resolved to <ion-datetime max="2022" locale="ja-JP" show-default-title="true" presentation="month-year" show-default-buttons="true" value="2022-04-19T04:20:00" class="ion-color ion-color-primary md show-month-and-year datetime-presentation-month-year datetime-size-fixed hydrated datetime-ready">…</ion-datetime> - taking element screenshot - disabled all CSS animations - waiting for fonts to load... - fonts loaded - attempting scroll into view action - waiting for element to be stable - captured a stable screenshot - 266 pixels (ratio 0.01 of all image pixels) are different. 164 | async expectLocalizedPicker(screenshot: ScreenshotFn, modifier?: string) { 165 | const modifierString = modifier === undefined ? '' : `-${modifier}`; > 166 | await expect(this.datetime).toHaveScreenshot(screenshot(`datetime-locale-${this.locale}${modifierString}-diff`)); | ^ 167 | } 168 | } 169 | at DatetimeLocaleFixture.expectLocalizedPicker (/ionic/src/components/datetime/test/locale/datetime.e2e.ts:166:33) at DatetimeLocaleFixture.expectLocalizedMonthYearPicker (/ionic/src/components/datetime/test/locale/datetime.e2e.ts:157:16) at /ionic/src/components/datetime/test/locale/datetime.e2e.ts:44:31
[Mobile Chrome] › src/components/radio/test/a11y/radio.e2e.ts:117:11 › radio: a11y - md/ltr/dark › radio: keyboard navigation - md/ltr/dark › tabbing should switch between radio groups: src/components/radio/test/a11y/radio.e2e.ts#L122
2) [Mobile Chrome] › src/components/radio/test/a11y/radio.e2e.ts:117:11 › radio: a11y - md/ltr/dark › radio: keyboard navigation - md/ltr/dark › tabbing should switch between radio groups Error: Timed out 5000ms waiting for expect(locator).toBeFocused() Locator: locator('#first-group ion-radio').first() Expected: focused Received: inactive Call log: - expect.toBeFocused with timeout 5000ms - waiting for locator('#first-group ion-radio').first() 9 × locator resolved to <ion-radio value="huey" role="radio" tabindex="0" aria-checked="true" class="md in-item radio-checked radio-label-placement-start hydrated">Huey</ion-radio> - unexpected value "inactive" 120 | 121 | await pageUtils.pressKeys('Tab'); > 122 | await expect(firstGroupRadios.nth(0)).toBeFocused(); | ^ 123 | 124 | await pageUtils.pressKeys('Tab'); 125 | await expect(secondGroupRadios.nth(0)).toBeFocused(); at /ionic/src/components/radio/test/a11y/radio.e2e.ts:122:47
[Mobile Chrome] › src/components/radio/test/a11y/radio.e2e.ts:130:11 › radio: a11y - md/ltr › radio: keyboard navigation - md/ltr › using arrow keys should move between enabled radios within group: src/components/radio/test/a11y/radio.e2e.ts#L134
1) [Mobile Chrome] › src/components/radio/test/a11y/radio.e2e.ts:130:11 › radio: a11y - md/ltr › radio: keyboard navigation - md/ltr › using arrow keys should move between enabled radios within group Error: Timed out 5000ms waiting for expect(locator).toBeFocused() Locator: locator('#first-group ion-radio').first() Expected: focused Received: inactive Call log: - expect.toBeFocused with timeout 5000ms - waiting for locator('#first-group ion-radio').first() 9 × locator resolved to <ion-radio value="huey" role="radio" tabindex="0" aria-checked="true" class="md in-item radio-checked radio-label-placement-start hydrated">Huey</ion-radio> - unexpected value "inactive" 132 | 133 | await pageUtils.pressKeys('Tab'); > 134 | await expect(firstGroupRadios.nth(0)).toBeFocused(); | ^ 135 | 136 | await page.keyboard.press('ArrowDown'); 137 | await expect(firstGroupRadios.nth(1)).toBeFocused(); at /ionic/src/components/radio/test/a11y/radio.e2e.ts:134:47
🎭 Playwright Run Summary
216 skipped 238 passed (2.3m)
🎭 Playwright Run Summary
414 passed (2.7m)
🎭 Playwright Run Summary
508 passed (2.9m)
🎭 Playwright Run Summary
1 flaky [Mobile Chrome] › src/components/datetime/test/locale/datetime.e2e.ts:42:11 › datetime: locale - md/ltr › ja-JP › month/year picker should not have visual regressions 1 skipped 513 passed (3.4m)
🎭 Playwright Run Summary
212 skipped 292 passed (3.5m)
🎭 Playwright Run Summary
4 skipped 590 passed (3.5m)
🎭 Playwright Run Summary
2 flaky [Mobile Chrome] › src/components/radio/test/a11y/radio.e2e.ts:130:11 › radio: a11y - md/ltr › radio: keyboard navigation - md/ltr › using arrow keys should move between enabled radios within group [Mobile Chrome] › src/components/radio/test/a11y/radio.e2e.ts:117:11 › radio: a11y - md/ltr/dark › radio: keyboard navigation - md/ltr/dark › tabbing should switch between radio groups 4 skipped 497 passed (3.6m)
🎭 Playwright Run Summary
627 passed (4.2m)
🎭 Playwright Run Summary
5 skipped 502 passed (4.7m)
🎭 Playwright Run Summary
10 skipped 482 passed (4.7m)
🎭 Playwright Run Summary
14 skipped 374 passed (5.1m)
🎭 Playwright Run Summary
498 passed (5.9m)
🎭 Playwright Run Summary
4 skipped 502 passed (6.0m)
🎭 Playwright Run Summary
4 skipped 501 passed (6.0m)
🎭 Playwright Run Summary
506 passed (6.3m)
🎭 Playwright Run Summary
14 skipped 494 passed (7.1m)
🎭 Playwright Run Summary
2 skipped 504 passed (7.1m)
🎭 Playwright Run Summary
5 skipped 551 passed (7.0m)
🎭 Playwright Run Summary
9 skipped 502 passed (7.3m)
🎭 Playwright Run Summary
8 skipped 506 passed (7.8m)

Artifacts

Produced during runtime
Name Size Digest
ionic-angular
653 KB
sha256:281b43522217688bbe4e68c550eaf33e4e87d4bde6f78e80f98e489652b463b8
ionic-angular-server
8.54 KB
sha256:ec04c7dc321f013cbadcad43ac1fd3a5cf1e0907b6bf93fc6854fa88108de60d
ionic-core
4.44 MB
sha256:475533fd71d7738b4fcb2268264d152a6bd3eb30a377a73e3e8b9c89b4fe6185
ionic-react
199 KB
sha256:342889dfd9453d677765d4d821f0b76473da5c704154615d8b2998af5abe2814
ionic-react-router
27.9 KB
sha256:ed49d3f7c4d44c094ff6bd1fb48d6e11a52be699b20cf67c6450e0259cca97a4
ionic-vue
221 KB
sha256:8e3e2dec36735a6356e6c8f99cc39442eae45ae39083bfa6e878a547ee1d89e4
ionic-vue-router
17.1 KB
sha256:4ece8f56de6e00f18ec4de0594fbb7feee0b33984ccbba933c26f26ffae011c5
test-results-1-20
442 KB
sha256:7a9c78bacc6c8be3448431c15801fa29b8be82d554bee0cc65bcd3685470f002
test-results-10-20
419 KB
sha256:e91fa322c09a16485fdbc425040bcf02ab38264a31045a9c31ed215585967410
test-results-11-20
1.61 MB
sha256:d3b556c4b3b1b06ce9732aaa9cb56cffa2292e9421431a9dda22878717e9bee4
test-results-12-20
436 KB
sha256:37e8eb60677f9e1862f1572c5b98446d1e5cd44850b1802a90bb8abca79391f3
test-results-13-20
449 KB
sha256:3ef99583fb0aa99c5f827abc848420a73b8bd2bceeb634cbc75b807365679c80
test-results-14-20
401 KB
sha256:c500a0b083048122d6477803c0de40d802c3b8987b4c089a969b5846fc1f8f9d
test-results-15-20
435 KB
sha256:f260dcd728080eb1a0fac54bcc5aa6c9b04c2470c16920825ed80f6c6a556653
test-results-16-20
421 KB
sha256:1d670942caace9a804c895ee4db9cfbdfb621dd1e65a63a7b0ebc8a0ae3bc468
test-results-17-20
542 KB
sha256:df1c981a7c5a97e0234088cee69e4b0b01c64ac972800b4e7c51ab3a4428b064
test-results-18-20
488 KB
sha256:df5645b83445cb767aeda59496364e881f14628fba1dc9312b208861795068a0
test-results-19-20
397 KB
sha256:2b0c1bd4c3d9d6adf3940e6cf193e05ee6106c1ca5b2a883b414685b5935df96
test-results-2-20
476 KB
sha256:c50dcfe7d3316af9e2794cfc38557b033144885f1271de64a082fc7a51cf8901
test-results-20-20
347 KB
sha256:ca6f1079d1778ad6cd63854c2c31b4105ba179e4ffe223130d17ae99abe3160b
test-results-3-20
421 KB
sha256:0bdf80abbe9b10919a2129b8b9f31021c64bd13e766b27ad68ed74097dbf23d7
test-results-4-20
528 KB
sha256:18a1aadd41074b62c0571b9def6a90917539e690776922a68bd0330db9c73ff2
test-results-5-20
448 KB
sha256:3e061afbdc208aff81cc7c805b79f37194d3171a36f1dc26c1602ac025b50bee
test-results-6-20
448 KB
sha256:de29e1519f5ecb2f5fd7e0fc2be9767c56b98952dbf7bb5c64fe9b4483d76489
test-results-7-20
336 KB
sha256:a544c45e4f4682f067a4dae2c4558752a44b3d04d6a53a610ae29dd982ed0f22
test-results-8-20
1.23 MB
sha256:5e64d795459cd4b60ba8537064e3806a6fc055b94c2b0fa8d74002ca7e580a0f
test-results-9-20
470 KB
sha256:53210b13b9228c2af2351dccda271d802fd21123b6c6f350390487bb8daf0373