-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(analytics,web): sets no-cors on analytics requests for web #8238
Conversation
See the following discussion for more details: invertase#7982 (reply in thread)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for posting this, and really, thanks for digging in and figuring it out. Much appreciated.
Do you think this line should go as it is redundant now?
Yup, done, also retested with that line removed and verified we still get an HTTP 204 from Google Analytics. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A thing of beauty - thanks again
It's in the publish queue now, should be out on npmjs.com in a minute |
Description
Requests to Google analytics for web aren't setting no-cors so requests are triggering CORS preflight and subsequently failing.
See the following discussion for more details: #7982 (reply in thread)
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Tested manually in Chrome. I verified that no CORS preflight is sent and that I received an HTTP 204 response from my Google analytics request.
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter