-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(auth, ios): factorId nil check #7541
fix(auth, ios): factorId nil check #7541
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - thanks a bunch for working through this. I'm sorry it is crashing for you and I'm certain we need a change here so I really appreciate the investigation
I've let some comments on the specific direction for the change and I'm curious for your thoughts on the comments - after a little conversation between us I'm sure we'll come up with something that we agree on and we can get a fix released for this
Hey @mikehardy, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks clean and easy to me - I'm a +1 on it - does it work for you to solve the crash in testing?
Already passed iOS, android code didn't change --> good to go |
Description
Sometimes the
hint.factorID
(in thefirebaseUserToDict
function) is retuningnil
value and this could cause app crash. I've tried to described my journey with this issue in this commentRelated issues
Fixes #7080
Release Summary
Auth module - nil check in the getJSFactorId function
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
🔥