Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize clean command by improving performance and adding error handling #854

Closed

Conversation

suojae
Copy link
Contributor

@suojae suojae commented Jan 25, 2025

Description

This PR refactors the clean command in _CleanMixin to improve performance. The key changes are:

  1. Optimized _cleanPackage logic:

    • Consolidated paths into a single iterable to reduce redundant operations.
  2. Enhanced cleanIntelliJ:

    • Added detailed logging for better debugging and traceability.

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

Checklist

Copy link

docs-page bot commented Jan 25, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/melos~854

Documentation is deployed and generated using docs.page.

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2025

CLA assistant check
All committers have signed the CLA.

@suojae suojae closed this Jan 25, 2025
@suojae suojae deleted the refactor/optimize-clean-command branch January 25, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants