Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed versioning for nested version fields #831

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

willroxby
Copy link
Contributor

@willroxby willroxby commented Jan 9, 2025

Description

As discussed in Discord I have modified the _setPubspecVersionForPackage method to allow for nested versions to be updated.

Context: https://discord.com/channels/295953187817521152/1059839794760392734/1326708821808119870

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

Copy link

docs-page bot commented Jan 9, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/melos~831

Documentation is deployed and generated using docs.page.

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise it looks good!

packages/melos/lib/src/commands/version.dart Show resolved Hide resolved
@spydon spydon enabled auto-merge (squash) January 9, 2025 12:35
@spydon spydon merged commit 4def209 into invertase:main Jan 9, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants