Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency sqlglot to >=23.4,<26.2 #10662

Merged
merged 2 commits into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ibis/backends/sql/compilers/mysql.py
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@

def visit_EndsWith(self, op, *, arg, end):
to = sge.DataType(this=sge.DataType.Type.BINARY)
return self.f.right(arg, self.f.char_length(end)).eq(sge.Cast(this=end, to=to))
return self.f.right(arg, self.f.length(end)).eq(sge.Cast(this=end, to=to))

Check warning on line 223 in ibis/backends/sql/compilers/mysql.py

View check run for this annotation

Codecov / codecov/patch

ibis/backends/sql/compilers/mysql.py#L223

Added line #L223 was not covered by tests

def visit_StartsWith(self, op, *, arg, start):
to = sge.DataType(this=sge.DataType.Type.BINARY)
Expand Down
1 change: 1 addition & 0 deletions ibis/backends/sql/dialects.py
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,7 @@ class Generator(TSQL.Generator):
sge.RegexpLike: (
lambda _, e: f"({e.this.sql('mysql')} RLIKE {e.expression.sql('mysql')})"
),
sge.Length: rename_func("char_length"),
}


Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ dependencies = [
"parsy>=2",
"python-dateutil>=2.8.2",
"pytz>=2022.7",
"sqlglot>=23.4,<26.1",
"sqlglot>=23.4,<26.2",
"toolz>=0.11",
"typing-extensions>=4.3.0",
]
Expand Down
4 changes: 2 additions & 2 deletions requirements-dev.txt

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 9 additions & 7 deletions uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading