Skip to content

Fixed tax method feature #208 #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

stefanomarra
Copy link

Added fixed tax method to provide a predefined value as a tax.

Description

Added fixed tax method as option in the tax method select and updated templates to handle the new method the right way.

Related Issue

The related issue is described here: #208

Motivation and Context

There are some cases where the tax calculation is fixed to a predefined amount.

How Has This Been Tested?

I tested the new feature manually by changed the tax method and added related jest tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have included a migration scheme (If type of change is breaking change)

@hql287
Copy link
Owner

hql287 commented Mar 27, 2018

Nice work! 👍

However, it's not quite obvious what changing the option from Default to Fixed mean. It's also a little bit confusing because the Amount's field label is Amount (%) which suggest the amount is a percentage.

Maybe we can:

  • Change the option's label from Fixed to Fixed Amount
  • Change the field's label from Amount (%) to Fixed Amount or Amount (Fixed). Or maybe even Amount will do just fine?

Amount Not Changed

@stefanomarra
Copy link
Author

@hql287 absolutely right. I will fix this

@hql287
Copy link
Owner

hql287 commented Apr 9, 2018

@stefanomarra: Any update on this?

@hql287 hql287 modified the milestones: Build 07 - v1.1.5, Sprint 1 Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants