Only load BridgeComponent controllers if the Hotwire Native user agent supports the component
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt supports the bridge component. This prevents unintended backwards incompatibility side effects for older clients that don't yet support a given bridge component.
jayohms
changed the title
BridgeComponent controllers if the Hotwire Native user agent supports the component
olivaresf
reviewed
Mar 12, 2025
olivaresf
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a
BridgeComponentcontroller would always load for any Hotwire Native client app. This has backwards-compatibility concerns depending on how theBridgeComponentcode was written.BridgeComponentcontrollers should only load for an app that explicitly supports the component via itsUser-Agent.With this change,
BridgeComponentcontrollers will only load on a client app if the component is provided as a supportedbridge-componentin theUser-Agent.