Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable chart animations if prefers-reduced-motion is enabled #23777

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

MindFreeze
Copy link
Contributor

@MindFreeze MindFreeze commented Jan 17, 2025

Proposed change

Disable animations for accessibility https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion
Proposed by @AlCalzone

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@MindFreeze
Copy link
Contributor Author

@bramkragten If we do another patch release, I think we should include this

@MindFreeze MindFreeze mentioned this pull request Jan 17, 2025
9 tasks
@MindFreeze MindFreeze added the Accessibility Related to accessibility for people with disabilities label Jan 18, 2025
@MindFreeze MindFreeze requested review from wendevlin and removed request for wendevlin January 22, 2025 07:54
@MindFreeze
Copy link
Contributor Author

The migration to echarts is ready now and includes this, so maybe it doesn't make sense to merge it like this with chart.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Related to accessibility for people with disabilities cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant