Issue-24: add tests to ensure coverage on all methods #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppeble
force-pushed
the
issue-24
branch
2 times, most recently
from
32af295 to
ba7d955
Compare
ppeble
force-pushed
the
issue-24
branch
5 times, most recently
from
72abd1c to
638bf59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through and audited all of our method-related tests. After this PR is merged we can be sure that every
functionis covered by a test in some form.This also changes the existing 'method' data to 'ruby' and other languages. I decided that trying to make a common logic setup was outside of the scope of this project. We'll maintain language-specific implementation of the various functions.
You can read the ADR for an explanation of the decisions behind this PR.