Improve Google subscription lookup on notification #2329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Google subscription notification contains a LinkedPurchaseToken field, lookup subscription OriginalTransactionId by that linked purchase token.
There was a problem hiding this comment.
Pull Request Overview
Enhance Google subscription notification handling to use the LinkedPurchaseToken when available and improve context propagation throughout subscription and purchase operations.
- Propagate
r.Context()instead ofcontext.Background()in various handlers for proper cancellation and deadlines. - Introduce logic to override the original purchase token with
LinkedPurchaseTokenwhen processing Google subscription notifications. - Update
storageSub.originalTransactionIdwith the linked token before upserting.
Comments suppressed due to low confidence (1)
server/core_subscription.go:1111
- Add tests covering the case where
gResponse.LinkedPurchaseTokenis non-empty to verify that the override ofpurchaseTokenand subsequent subscription lookup works correctly.
if gResponse.LinkedPurchaseToken != "" {
Use propagate request context in notifications callback.
sesposito
force-pushed
the
spe/google-sub-notif-handling
branch
from
0c8efd6 to
76c1444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Google subscription notification contains a LinkedPurchaseToken field, lookup subscription OriginalTransactionId by that linked purchase token.