Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly install OpenShift CLI tools as not included in latest GitHub Runner image [DI-396] [5.5.2] #866

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

Backport of #859

In #850, we use the
`openshift-tools-installer` to install OpenShift tools, but [following
testing](https://hazelcast.slack.com/archives/C05LM8B80UT/p1736508941644619?thread_ts=1736438770.790189&cid=C05LM8B80UT)
there were some issues:

- `preflight` and `oc` must be installed from _different_ mirrors as
they are [not in the same
one](https://github.com/redhat-actions/openshift-tools-installer?tab=readme-ov-file#supported-tools)
- `preflight` is installed with a different name vs when simply unpacked

Testing outputs:
- [Example action showing installation
success](https://github.com/hazelcast/hazelcast-docker/actions/runs/12709131411/job/35427518232)
- [`5.3.8` deployed using these
changes](https://github.com/hazelcast/hazelcast-docker/actions/runs/12712052672)
(via [a
branch](https://github.com/hazelcast/hazelcast-docker/tree/refs/heads/5.3.8-with-%60oc%60-fix))
@JackPGreen JackPGreen requested a review from nishaatr January 13, 2025 15:54
@JackPGreen JackPGreen requested a review from a team as a code owner January 13, 2025 15:54
@JackPGreen JackPGreen merged commit 8cdcdd2 into 5.5.2 Jan 13, 2025
4 of 7 checks passed
@JackPGreen JackPGreen deleted the DI-396-5.5.2 branch January 13, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants