-
Notifications
You must be signed in to change notification settings - Fork 9
add vulnerability scan #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add279c
to
866888c
Compare
4df23ca
to
677225e
Compare
6ecbafa
to
101a320
Compare
c01dba0
to
dfa5fdf
Compare
dfa5fdf
to
e4bfbbe
Compare
danieljharvey
approved these changes
May 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all seems very sensible.
Co-authored-by: Daniel Harvey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds vulnerability scanning for new connector releases
How
Three new commands have been added:
download-artifacts
: This command is responsible for downloading connector artifacts (CLI Plugins, targz file, Docker Images)scan trivy
: This command scans the downloaded connector artifacts using Trivyscan gokakashi
: This commands scans all connector docker images using GokakashiTrivy scan runs on new PRs
Gokakashi scan runs once a day periodically
Review
This PR refactors and changes a few files. I've broken the changes down by commits. I'd recommend using commits to review this.
Tests
Tests for the new commands (and functions) are not yet present. I'll be adding them in a follow up PR