-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix for HclCache in PartialParseConfigFile is never used #4523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix for HclCache in PartialParseConfigFile is never used #4523
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 Walkthrough""" WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant PartialParseConfigFile
participant HclCache
participant HclParser
Caller->>PartialParseConfigFile: Call with configPath
PartialParseConfigFile->>HclCache: Get(cacheKey)
alt Cache hit
HclCache-->>PartialParseConfigFile: Return cached file
else Cache miss
PartialParseConfigFile->>HclParser: ParseFromFile(configPath)
HclParser-->>PartialParseConfigFile: Return parsed file
PartialParseConfigFile->>HclCache: Put(cacheKey, parsed file)
end
PartialParseConfigFile-->>Caller: Return TerragruntConfig
Assessment against linked issues
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Hi, noticed failing lint tests:
|
Description
Fixes #4522.
This PR resolves the issue described in the referenced issue: the HclCache was never used in PartialParseConfigFile.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Fix: improving caching behavior during hcl files parsing.
Summary by CodeRabbit
New Features
Tests