Remove github.com/elastic/go-elasticsearch dependency #55319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library was largely used for tests which were easily updated to leverage the http library directly. The only other use of the library was for `types.ErrorClause` which was removed in favor of vendoring the subset of the type needed by the elastic engine.
rosstimothy
added
no-changelog
github-actions
bot
added
database-access
github-actions
bot
requested review from
greedy52,
hugoShaka,
marcoandredinis and
tigrato
tigrato
approved these changes
May 31, 2025
|
I am waiting for the day where go compiler is smart enough to discard test libraries and test imported packages :sad: |
hugoShaka
approved these changes
May 31, 2025
public-teleport-github-review-bot
bot
removed request for
marcoandredinis and
greedy52
zmb3
approved these changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library was largely used for tests which were easily updated to leverage the http package directly. The only other use of the library was for
types.ErrorClausewhich was removed in favor of vendoring the subset of the type needed by the elastic engine.