feat: add SQS, S3, and KMS support for AWS Access Graph integration #55300
+394
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tigrato
commented
May 30, 2025
tigrato
commented
- Updated configuration to acept SQSQueueURL, CloudTrailBucket, and KMSKeyARNs.
- Updated integration commands to accept new parameters for SQS and S3.
- Updated configuration to acept SQSQueueURL, CloudTrailBucket, and KMSKeyARNs. - Updated integration commands to accept new parameters for SQS and S3. Signed-off-by: Tiago Silva <[email protected]>
tigrato
added
no-changelog
mvbrock
approved these changes
May 30, 2025
| @@ -67,6 +86,25 @@ func (r *AccessGraphAWSIAMConfigureRequest) CheckAndSetDefaults() error { | |||
| r.IntegrationRoleTAGPolicy = defaultPolicyNameForTAGSync | |||
| } | |||
|
|
|||
| if r.SQSQueueURL != "" || r.CloudTrailBucket != "" { | |||
| if r.SQSQueueURL == "" || r.CloudTrailBucket == "" { | |||
| return trace.BadParameter("if CloudTrailBucket is set, SQSQueueURL must also be set") | |||
There was a problem hiding this comment.
Would reword to Both CloudtrailBucket and SQSQueueURL must be set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.