api/client: support dialing and creating the client separately #55293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #55170, we added support for wrapping `tbot`'s gRPC connection so that we can handle the auth server being unavailable on-startup. This PR makes it possible to create a Client from an existing (i.e. wrapped) gRPC connection. It's a little bit inefficient in that `lib/auth/authclient` still creates an HTTP client which we never use, and it feels like it'd be cleaner to separate them at a lower-level - but this seems like the least disruptive approach. changelog: api/client: support for creating a client from an existing gRPC connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #55170, we added support for wrapping
tbot's gRPC connection so that we can handle the auth server being unavailable on-startup. This PR makes it possible to create a Client from an existing (i.e. wrapped) gRPC connection.It's a little bit inefficient in that
lib/auth/authclientstill creates an HTTP client which we never use, and it feels like it'd be cleaner to separate them at a lower-level - but this seems like the least disruptive approach.changelog: api/client: support for creating a client from an existing gRPC connection