Unified resources: Make "Show requestable resources" clickable #55289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravicious
added
no-changelog
kimlisa
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the text next to the toggle wasn't clickable.
By default, when you pass children to
<Toggle>, they end up being used as a label for the toggle and the label is shown to the right of the toggle. Grepping through the project, it seems to be the most common use case for<Toggle>. This particular callsite was an outlier.The flicker in the recordings is due to how the story is written, I didn't want to spend time on improving it. The preferences in the story are not even interactive without https://github.com/gravitational/teleport.e/pull/6599.
before.mov
after.mov