fix: don't cache an incorrect PIV PIN #54614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avatus
approved these changes
May 8, 2025
rosstimothy
approved these changes
May 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Joerger
added a commit
that referenced
this pull request
May 10, 2025
* Verify PIV PIN before we cache it; Fix lint for pincache.go with build tag. * Add local test for PIN caching in the YubiKey service. * Minor fixes.
Joerger
added a commit
that referenced
this pull request
May 10, 2025
* Verify PIV PIN before we cache it; Fix lint for pincache.go with build tag. * Add local test for PIN caching in the YubiKey service. * Minor fixes.
Joerger
added a commit
that referenced
this pull request
May 12, 2025
* Verify PIV PIN before we cache it; Fix lint for pincache.go with build tag. * Add local test for PIN caching in the YubiKey service. * Minor fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #53976 to prevent an incorrect PIN from being cached by verifying the PIN against the YubiKey first.
Changelog: Fix an issue with PIV PIN caching where a PIN that is incorrect would be cached.
Note: Once go-piv/piv-go#174 gets merged and released, I can take care of the TODO about the redundant PIN verification taking place.