Skip to content

Semantic nullability document directive #4271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: 16.x.x
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
7ca49b2
New GraphQLSemanticNonNull type
benjie Sep 14, 2024
16a2114
Handle isNonNullType
benjie Sep 14, 2024
2b13389
More fixes
benjie Sep 14, 2024
04a8e91
More fixes
benjie Sep 14, 2024
076a735
Yet more updates
benjie Sep 14, 2024
c2196a0
Recognize in introspection, enable disabling null bubbling
benjie Sep 14, 2024
f588046
Lint fixes
benjie Sep 14, 2024
fa3f177
More missing pieces
benjie Sep 14, 2024
b5e81bd
More fixes
benjie Sep 14, 2024
1f6a019
Fix schema
benjie Sep 14, 2024
491f49b
Fix another test
benjie Sep 14, 2024
3a91590
More minor test fixes
benjie Sep 14, 2024
56db880
Fix introspection test
benjie Sep 14, 2024
593ce44
Add support for * to lexer
benjie Sep 14, 2024
1311906
Allow specifying errorPropagation at top level
benjie Sep 14, 2024
9d706d2
Factor into getIntrospectionQuery
benjie Sep 14, 2024
e9f9628
Lint
benjie Sep 14, 2024
eb9b6c8
Prettier
benjie Sep 14, 2024
3a900a9
parser tests passing
twof Oct 30, 2024
557a986
Add semantic optional type
twof Nov 7, 2024
95484ba
printer and parser tests passing
twof Nov 7, 2024
07e4646
some new semanticNullability execution tests
twof Nov 8, 2024
6fac3b5
SemanticNonNull halts null propagation
twof Nov 8, 2024
d11a647
SemanticOptional cleared
twof Nov 8, 2024
0a8b68f
logging cleanup
twof Nov 8, 2024
24474fa
rename to SemanticNullable
twof Nov 8, 2024
af58560
better SemanticNullable docs
twof Nov 8, 2024
668f3dc
move semantic nullability tests to their own file
twof Nov 8, 2024
63345de
fix git status
twof Nov 8, 2024
c472b9e
run prettier
twof Nov 8, 2024
163785d
Add comment to parser about document directive
twof Nov 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More minor test fixes
  • Loading branch information
benjie committed Sep 20, 2024
commit 3a91590cc869bd0fde133e721a3369c9ea2559a8
2 changes: 1 addition & 1 deletion src/__tests__/starWarsIntrospection-test.ts
Original file line number Diff line number Diff line change
@@ -42,10 +42,10 @@ describe('Star Wars Introspection Tests', () => {
{ name: '__TypeKind' },
{ name: '__Field' },
{ name: '__InputValue' },
{ name: '__TypeNullability' },
{ name: '__EnumValue' },
{ name: '__Directive' },
{ name: '__DirectiveLocation' },
{ name: '__TypeNullability' },
],
},
});
2 changes: 2 additions & 0 deletions src/execution/__tests__/executor-test.ts
Original file line number Diff line number Diff line change
@@ -263,6 +263,7 @@ describe('Execute: Handles basic execution tasks', () => {
'rootValue',
'operation',
'variableValues',
'errorPropagation',
);

const operation = document.definitions[0];
@@ -275,6 +276,7 @@ describe('Execute: Handles basic execution tasks', () => {
schema,
rootValue,
operation,
errorPropagation: true,
});

const field = operation.selectionSet.selections[0];