Skip to content

Unref the pgServices cache timer to prevent blocking process exit #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsmnbom
Copy link

@jsmnbom jsmnbom commented Jun 29, 2025

Description

Fixes #2609

Performance impact

unknown - should be none
possibly positive in case user code anywhere is waiting for process exit?

Security impact

unknown - should be none.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

I have no idea how/if this would be tested - sorry, and it's such a tiny change so dunno about the others.

@github-project-automation github-project-automation bot moved this to 🌳 Triage in V5.0.0 Jun 29, 2025
Copy link

changeset-bot bot commented Jun 29, 2025

⚠️ No Changeset found

Latest commit: d9a4170

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🌳 Triage
Development

Successfully merging this pull request may close these issues.

getWithPgClientFromPgService prevents quick exit
1 participant