Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash when no error tag present #3

Merged
merged 1 commit into from
Nov 14, 2020
Merged

Don't crash when no error tag present #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/ConstraintErrorTagsPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,18 @@ async function ConstraintErrorTagsPlugin(_, { pgConfig }) {
constraintsWithErrorTags = rows
.map(({ description, ...rest }) => {
const error = parseTags(description).tags.error;
if (typeof error !== "string") {
throw new Error(
`ConstraintErrorTagsPlugin: expected error smart tag on "${rest.constraint}" to be a string, but got: ${error}.`
);
if (error) {
if (typeof error !== "string") {
throw new Error(
`ConstraintErrorTagsPlugin: expected error smart tag on "${rest.constraint}" to be a string, but got: ${error}.`
);
}
return {
...rest,
error,
};
}
return {
...rest,
error,
};
return rest;
})
.filter(({ error }) => Boolean(error));
});
Expand Down