Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scheduling constraints (backport k239) #16048

Open
wants to merge 1 commit into
base: k239
Choose a base branch
from

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Jan 31, 2025

Backport b45a31e from #16045


What this PR does / why we need it:

Makes the scheduling constraint more flexible / gives more options to satisfy what we need for our AWS clusters.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Signed-off-by: Trevor Whitney <[email protected]>
(cherry picked from commit b45a31e)
@loki-gh-app loki-gh-app bot requested a review from a team as a code owner January 31, 2025 23:27
@loki-gh-app loki-gh-app bot added the size/XS label Jan 31, 2025
@loki-gh-app loki-gh-app bot requested a review from slim-bean January 31, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant