Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chunks): support custom MaxIdleConns and MaxIdleConnsPerHost in AWS s3 storage client #15976

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

paulojmdias
Copy link

What this PR does / why we need it:

Currently, the S3 client used by chunks has the MaxIdleConns and MaxIdleConnsPerHost hardcoded with 200 values. This PR allows both values to be configurable from the client side but keeps the previous hardcoded values as default values.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.

@paulojmdias paulojmdias requested a review from a team as a code owner January 27, 2025 15:40
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jan 27, 2025
@mveitas
Copy link
Contributor

mveitas commented Jan 27, 2025

@paulojmdias Was there a specific bottleneck or issue with the S3 client this fixes?

@paulojmdias
Copy link
Author

@paulojmdias Was there a specific bottleneck or issue with the S3 client this fixes?

Technically no, but we face these hardcoded values in the code during our performance tests. I take the opportunity to make it configurable using the same hardcoded values as default to avoid creating any unexpected change.

Signed-off-by: Paulo Dias <[email protected]>
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] Configuration docs updates LGTM.

Someone from the engineering team will have to approve the Go changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants