Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix, FilePart, and _parsePart; #215

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

huanguan1978
Copy link

Copy link

google-cla bot commented Sep 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Author

@huanguan1978 huanguan1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finish review

Copy link
Author

@huanguan1978 huanguan1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finish review

Copy link

@iqbalbhatti49 iqbalbhatti49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The new implementation introduces support for inlineData and fileData content parts. Great work in enhancing functionality!
  • Proper handling of inlineData with DataPart and decoding using base64Decode is a smart addition.
  • FilePart implementation includes clear handling of mimeType and fileUri, with serialization via toJson()—nicely structured!
  • Adding executableCode support provides a foundation for future extensibility.

Overall, this update significantly improves the code's capabilities—excellent work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants