-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix, FilePart, and _parsePart; #215
base: main
Are you sure you want to change the base?
Conversation
FilePart Api ref: https://ai.google.dev/api/caching#FileData
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finish review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finish review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The new implementation introduces support for
inlineData
andfileData
content parts. Great work in enhancing functionality! - Proper handling of
inlineData
withDataPart
and decoding usingbase64Decode
is a smart addition. FilePart
implementation includes clear handling ofmimeType
andfileUri
, with serialization viatoJson()
—nicely structured!- Adding
executableCode
support provides a foundation for future extensibility.
Overall, this update significantly improves the code's capabilities—excellent work!
FilePart Api ref: https://ai.google.dev/api/caching#FileData