Skip to content

Add endpoint deleting workflow run #34337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 57 commits into from
May 13, 2025
Merged

Add endpoint deleting workflow run #34337

merged 57 commits into from
May 13, 2025

Conversation

NorthRealm
Copy link
Contributor

@NorthRealm NorthRealm commented May 1, 2025 •
edited
Loading

Add endpoint deleting workflow run
Resolves #26219

/claim #26219

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 1, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels May 1, 2025
@NorthRealm NorthRealm marked this pull request as ready for review May 2, 2025 10:22
@github-actions github-actions bot added modifies/translation modifies/templates This PR modifies the template files labels May 3, 2025
@NorthRealm NorthRealm requested a review from wxiaoguang May 13, 2025 16:03
wxiaoguang
wxiaoguang reviewed May 13, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

@ChristopherHX would you like to take a look if you have time?

Thank you all.

@NorthRealm NorthRealm requested a review from ChristopherHX May 13, 2025 17:54
@NorthRealm
Copy link
Contributor Author

Test is failing 😕

@NorthRealm
Copy link
Contributor Author

At line 587 ctx.JSONError(ctx.Tr("error.not_found"))
Return 400 or 404?

@wxiaoguang
Copy link
Contributor

Test is failing 😕

Because now we use JSONError for error messages, then the error message will be correctly displayed on the UI

@ChristopherHX
Copy link
Contributor

At line 587 ctx.JSONError(ctx.Tr("error.not_found"))
Return 400 or 404?

I assume 400 is correct here like in

gitea/routers/web/repo/branch.go

Line 267 in ad5234f

ctx.JSONError(ctx.Tr("error.not_found"))

@NorthRealm
Copy link
Contributor Author

At line 587 ctx.JSONError(ctx.Tr("error.not_found"))
Return 400 or 404?

I assume 400 is correct here like in

gitea/routers/web/repo/branch.go

Line 267 in ad5234f

ctx.JSONError(ctx.Tr("error.not_found"))

I mean for that line, should use ctx.JSONError 400, or something else for 404?
But yeah whatever. Good for UI display.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented May 13, 2025 •
edited
Loading

I added JSONErrorNotFound in 8012a7e , I think it will be useful in the future.

And frontend code works with any 40x code:

image

ChristopherHX
ChristopherHX approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 13, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) May 13, 2025 18:47
@NorthRealm
Copy link
Contributor Author

Hey @wxiaoguang
After this pr gets finished, backport to 1.24?

@wxiaoguang
Copy link
Contributor

wxiaoguang commented May 13, 2025 •
edited
Loading

After this pr gets finished, backport to 1.24?

Personally I think (usually) no, because it is a feature-like change (a lot of code changes).

But if many users & contributors & maintainers would like to backport, we could try. So it depends IMO.

@wxiaoguang wxiaoguang merged commit 1e2f351 into go-gitea:main May 13, 2025
26 checks passed
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 14, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9347855 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Add endpoint deleting workflow run (go-gitea#34337)
  Fix remove org user failure on mssql (go-gitea#34449)
  Fix repo broken check (go-gitea#34444)
  Fix comment textarea scroll issue in Firefox (go-gitea#34438)
  Fix releases sidebar navigation link (go-gitea#34436)
@NorthRealm NorthRealm deleted the delete-run-1 branch May 14, 2025 05:29
@NorthRealm NorthRealm mentioned this pull request May 14, 2025
Merged
lunny pushed a commit that referenced this pull request May 14, 2025
@NorthRealm
Fix Workflow run Not Found page (#34459)
dd500ce 
Related:
#34337 (comment)
#34337 (comment)
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 15, 2025
@NorthRealm @GiteaBot
Fix Workflow run Not Found page (go-gitea#34459)
8071b0f 
Related:
go-gitea#34337 (comment)
go-gitea#34337 (comment)
@GiteaBot GiteaBot mentioned this pull request May 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@ChristopherHX ChristopherHX ChristopherHX approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

Delete workflow runs
6 participants
@NorthRealm @inxcts @wxiaoguang @ChristopherHX @lunny @GiteaBot