Skip to content

fix(gnoland): genesis and e2e #4553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Conversation

moul
Copy link
Member

@moul moul commented Jul 24, 2025

  • making e2e not using --skip flag
  • adding go unit test for lazy without skip
  • fixing genesis: private module support (@moul)
    -> done by enabling --skip-genesis-sig-verification.
    We can eventually find a better way later, but for our current needs, we don't require more.
  • rename "SkipGenesisVerification" -> "SkipGenesisSigVerification" (addresses feat: add genesis packages with transaction signing #3280)
  • fixing genesis: "testing" import
  • @gfanton: improve start lazy test by checking rpc endpoint

Related with #4548

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jul 24, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: moul/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gno.land/cmd/gnoland/root.go 0.00% 10 Missing ⚠️
contribs/gnokms/internal/common/flags.go 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@moul moul changed the title dev/moul/fix e2e fix(gnoland): genesis and e2e Jul 24, 2025
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Jul 25, 2025
@gfanton gfanton marked this pull request as ready for review July 25, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐳 devops 🛠️ gnodev 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: No status
Status: 📥 Inbox
Status: Triage
Development

Successfully merging this pull request may close these issues.

3 participants