-
Notifications
You must be signed in to change notification settings - Fork 420
fix(p/grc721): OriginCaller -> PreviousRealm #4547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks basic_nft_test.go
failed, should also update it.
@ltzmaxwell fixed all tests 136119a |
Description
When set to
OriginCaller
, a situation occurs where NFT ownership cannot be transferred to other contracts, preventingMint
orApprove
operations (we can think of a flow like user -> position -> staker). Therefore, we changed the caller to PrevRealm to handle this appropriately.cc @jinoosss