-
Notifications
You must be signed in to change notification settings - Fork 420
feat(gnoweb): activate default goldmark extensions #4501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🛠 PR Checks Summary🔴 Changes related to gnoweb must be reviewed by its codeowners Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, can you take the opportunity to move the extensions initialization into markdown? (check my comment)
This PR aims to activate the default Goldmark missing extensions. It enhances the markdown rendering capabilities in gnoweb: ## Changes Made - Added extension.TaskList to enable task list support (GitHub-style task lists) - Added extension.Footnote to enable footnote support (Supports academic-style footnotes) - Both extensions are now included in the default markdown renderer configuration ## Syntax - **TaskList**: Uncommented and enhanced the existing task list section with examples showing both completed (`- [x]`) and pending (`- [ ]`) tasks - **Footnote**: Added a new comprehensive section demonstrating footnote usage with proper syntax: `[^1]` for references and `[^1]`: content for definitions ## Impact - Low risk: These are official Goldmark extensions with stable APIs - Backward compatible: No breaking changes to existing markdown content - Enhancement: Adds features we lost with winter gnoweb updates. ## UI Improvements Added ### TaskList Enhancements - **Gno-Styled Checkboxes**: Tasks are now styled in coherence with future form inputs from PR gnolang#4438 - Disabled checkboxes are rendered in a different style ### Footnote UX Improvements - **Enhanced Anchor Positioning:** Better positioning of superscript footnote references - **Improved Scroll Behavior:** Fixed margin scroll top to properly view anchors under the header - **Visual Highlighting:** Footnotes are now highlighted with background and subtle emphasis during scroll (visual feedback) ## Screenshots <img width="1049" height="921" alt="Capture d’écran 2025-07-15 à 16 04 03" src="https://github.com/user-attachments/assets/e2fae2b3-b1ce-4793-8d11-4285e012853e" /> <img width="1055" height="168" alt="Capture d’écran 2025-07-15 à 15 26 55" src="https://github.com/user-attachments/assets/51a4c9ab-f53c-4af3-87ef-c9192018b9dd" /> --------- Co-authored-by: Manfred Touron <[email protected]>
This PR aims to activate the default Goldmark missing extensions. It enhances the markdown rendering capabilities in gnoweb:
Changes Made
Syntax
- [x]
) and pending (- [ ]
) tasks[^1]
for references and[^1]
: content for definitionsImpact
UI Improvements Added
TaskList Enhancements
Footnote UX Improvements
Screenshots