-
Notifications
You must be signed in to change notification settings - Fork 420
feat(govdao): emit event on proposal creation to link tx to proposal #4455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(govdao): emit event on proposal creation to link tx to proposal #4455
Conversation
Signed-off-by: Norman <[email protected]>
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
What about adding events to all funcs? Vote, CreateProp, ExecuteProp Makes sense to me, we should do it here |
Signed-off-by: Norman <[email protected]>
I wanted to keep this minimal to allow for easy merge without too much debate and unlock us on proposal audit tooling |
I confirm, just wanted to move fast and iterate once minimalism is done. 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just left comments on the placement. Waiting on @ajnavarro to confirm 🙏
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ok, merging with multiple approvals here to unblock Teritori; let's revisit/add more events in the govdao implementation. |
This emit an event at proposal creation to allow tools to link a proposal to the tx that created it. The main goal is to help mitigate ignocent proposals.