Skip to content

chore(boards2): add txtar and improve CreateBoard doc #4411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: devx/feature/boardsv2
Choose a base branch
from

Conversation

n0izn0iz
Copy link
Contributor

Add a sanity check txtar that tests:

  • Board creation
  • Member invite
  • Thread creation
  • Reply
  • Member removal

Also improves the doc of CreateBoard to be explicit about board name constraints

The txtar can be vastly improved but it's a good base IMO

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jun 24, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@n0izn0iz n0izn0iz marked this pull request as draft June 24, 2025 14:07
@n0izn0iz n0izn0iz marked this pull request as ready for review June 24, 2025 14:13
@Kouteki Kouteki moved this from Triage to In Review in 🧙‍♂️gno.land core team Jun 30, 2025
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@@ -32,6 +32,7 @@ func init() {
gPerms = initRealmPermissions(
"g16jpf0puufcpcjkph5nxueec8etpcldz7zwgydq", // @devx
"g1manfred47kzduec920z88wfr64ylksmdcedlf5", // @moul
"g1mtmrdmqfu0aryqfl4aw65n35haw2wdjkh5p4cp", // @test123 -> for txtar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not do this. But i think Txtar can pretend being @devx or @moul, cc @gfanton.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we could delete this line, otherwise we should remove the @test123 user each time after deploying boards

Copy link
Member

@jeronimoalbi jeronimoalbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still think we should aim to remove the @test123 user from the initial list of board realm admins to avoid potential security issues if the user is not removed right after boards realm is deployed

@n0izn0iz
Copy link
Contributor Author

n0izn0iz commented Jul 24, 2025

I could do something similar to govdao txtars, will investigate, don't merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤝 contribs 📦 ⛰️ gno.land Issues or PRs gno.land package related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: In Progress
Status: In Review
Development

Successfully merging this pull request may close these issues.

4 participants