-
Notifications
You must be signed in to change notification settings - Fork 420
chore(boards2): add txtar and improve CreateBoard doc #4411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devx/feature/boardsv2
Are you sure you want to change the base?
chore(boards2): add txtar and improve CreateBoard doc #4411
Conversation
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):No automated checks match this pull request. ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Signed-off-by: Norman <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
@@ -32,6 +32,7 @@ func init() { | |||
gPerms = initRealmPermissions( | |||
"g16jpf0puufcpcjkph5nxueec8etpcldz7zwgydq", // @devx | |||
"g1manfred47kzduec920z88wfr64ylksmdcedlf5", // @moul | |||
"g1mtmrdmqfu0aryqfl4aw65n35haw2wdjkh5p4cp", // @test123 -> for txtar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if we could delete this line, otherwise we should remove the @test123
user each time after deploying boards
Co-authored-by: Manfred Touron <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still think we should aim to remove the @test123
user from the initial list of board realm admins to avoid potential security issues if the user is not removed right after boards realm is deployed
I could do something similar to govdao txtars, will investigate, don't merge |
Add a sanity check txtar that tests:
Also improves the doc of CreateBoard to be explicit about board name constraints
The txtar can be vastly improved but it's a good base IMO