-
Notifications
You must be signed in to change notification settings - Fork 420
feat: add a generic treasury pkg and integrate it to the govdao v3 #4374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving some comments, didn't go through the whole thing yet. Need to go on a plane, coming back to this in a bit
Closes #4094 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
@moul @zivkovicmilos |
I discussed this point with @zivkovicmilos on another discussion channel, and we concluded the current limitation to DAO members was enough to merge this PR as is. We will potentially add filters (dynamic or not) in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some performance improvements that might cause node crashes when a lot of transactions are rendered.
Also, I proposed a solution to avoid having public functions only intended for tests.
Apart from that, LGTM. We can merge what we have and add these improvements later on, to start iterating.
This PR:
p/demo/treasury
package meant to be generic / reusable by other Realms and DAOs. It can use multipleBanker
, currently two are implemented:std.Coins
bankerr/gov/dao/v3/treasury
Realms that use thisp/demo/treasury
package.NewTreasuryPaymentRequest()
method to thegovdao
.There are some 'NOTE' comments in these changes on points where I was uncertain.
Also I'm not sure if the path are relevant for both
p/demo/treasury
andp/aeddi/utils
packages.To Do:
p/nt/treasury
andp/aeddi/panictoerr
packages.gno.land/pkg/integration/testdata/govdao_proposal_treasury_payment.txtar
Depends on #4373.