"unix" should be added to conn_tmap on illumos/SunOS too #2549
Conversation
| @@ -22,6 +22,7 @@ XXXX-XX-XX | |||
| - 2542_: if system clock is updated `Process.children()`_ and | |||
| `Process.parent()`_ may not be able to return the right information. | |||
| - 2545_: [illumos]: Fix handling of MIB2_UDP_ENTRY in `net_connections()`_. | |||
| - 2547_: [illumos]: Add "unix" to conn_tmap on illumos/SunOS too. | |||
There was a problem hiding this comment.
What's the change exactly? Was only the unit test that was broken or the functionality (net_connections()) per se? If the former, please explain what was the problem (exception? crash?).
There was a problem hiding this comment.
The change exactly is to add "unix" back to conn_tmap as it was before December 2024.
I found the issue by running psutil's tests. I do not use psutil for anything specific. I just package it for OpenIndiana (and so I run its tests to make sure it works), primarily because it is needed by some other Python projects packaged.
There was a problem hiding this comment.
It looks like UNIX sockets are not supported on SunOS, that's why I removed it:
Line 262 in 11fd402
There was a problem hiding this comment.
How can I easily confirm that (or prove it is wrong)?
Summary
TestConnectedSocket.test_unixfails #2547Description
Commit 5d4be42 conditionally removed the addition of "unix" to
conn_tmapfor SUNOS. This seems to be wrong and is causing four tests to fail (see #2547 for details). This change reverts the offending part of 5d4be42 to avoid test failures documented in #2547.