Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for age identity with passphrase #1400

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

support for age identity with passphrase #1400

wants to merge 2 commits into from

Conversation

tomaszduda23
Copy link
Contributor

@tomaszduda23 tomaszduda23 commented Dec 30, 2023 •
edited
Loading

Solves #933. It is basically rip of from https://github.com/FiloSottile/age/blob/101cc8676386b0503571a929a88618cae2f0b1cd/cmd/age/parse.go#L143. It looks that sops already support reading passwords similar way for PGP

It also support password prompt by gpg-agent. It requires merge of getsops/gopgagent#1

@tomaszduda23 tomaszduda23 changed the title add support for passphrase for age support for age identity with passphrase Dec 31, 2023
@tomaszduda23 tomaszduda23 mentioned this pull request Dec 31, 2023
Open
felixfontein
felixfontein reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converting to draft until the agent from getsops is used.

age/keysource.go Outdated Show resolved Hide resolved
@felixfontein felixfontein marked this pull request as draft January 2, 2024 15:47
@tomaszduda23 tomaszduda23 marked this pull request as ready for review January 2, 2024 18:28
@felixfontein @tomaszduda23
Merge pull request getsops#1743 from getsops/dependabot/go_modules/go…
5381112 
…-dfc8ceccf9

build(deps): Bump the go group with 7 updates
@tomaszduda23
Copy link
Contributor Author

@felixfontein would you mind review again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/keyservice enhancement keyservice/age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomaszduda23 @felixfontein