ref(k8s): Add a k8s for the taskworker deployment #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a k8s file for deploying the taskworker image. It also makes a few QoL improvements: - Replace SimpleTaskWorker with ConfigurableTaskWorker - Add more logging to the worker - Add a backoff to the worker, so that if there are no messages it doesn't spam logs - Update the taskbroker image - Fix a bug in the worker where it wouldn't process tasks fetched in the update
john-z-yang
approved these changes
Jan 9, 2025
markstory
approved these changes
Jan 9, 2025
enochtangg
reviewed
Jan 9, 2025
| @@ -32,7 +31,7 @@ def manage_taskworker( | |||
| shutdown_event: threading.Event, | |||
| ) -> None: | |||
| print(f"[taskworker_{worker_id}] Starting taskworker_{worker_id}") | |||
| worker = SimpleTaskWorker( | |||
| worker = ConfigurableTaskWorker( | |||
There was a problem hiding this comment.
Just FYI: I also updated this test in my PR. If this goes out first, I'll fix it: #112
enochtangg
approved these changes
Jan 9, 2025
Co-authored-by: Mark Story <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a k8s file for deploying the taskworker image. It also makes a few QoL improvements: